Fix resample reduce_data bug introduced in #582#600
Merged
djhoese merged 1 commit intopytroll:masterfrom Jan 31, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #600 +/- ##
==========================================
+ Coverage 78.07% 78.13% +0.06%
==========================================
Files 136 136
Lines 19531 19552 +21
==========================================
+ Hits 15248 15277 +29
+ Misses 4283 4275 -8
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On slack @adybbroe pointed out that resampling was broken in current master. This was caused by some changes in #582 by @pnuu as part of refactoring the code. Bottom line, the
source_areavariable needs to represent the "reduced" area after reducing has been done.git diff origin/master -- "*py" | flake8 --diff